Skip to content

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Aug 17, 2025

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Is this some kind of tmp fix resolved, therefore not needed anymore?

As its only in this file and not in its companions.

image

@elasticsearchmachine elasticsearchmachine added v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label labels Aug 17, 2025
steps:
- label: part-1
command: |
.buildkite/scripts/spotless.sh # This doesn't have to be part of part-1, it was just a convenient place to put it
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be redundant wasting resources on every commit.

@breskeby
Copy link
Contributor

This is on purpose fixing on the fly accidentally committed spotless issues.

@Pankraz76
Copy link
Author

ok sorry. The comment reads different to me but im not so good so please excuse this.

But why is it only on this on and not on the windows and other OS versions? Might adjust comment then to prevent any further.

@breskeby breskeby closed this Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants