Skip to content

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Aug 17, 2025

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

as requested by @DaveCTurner

Please excuse my recent wording, no offence ment. Real once take critics for good and improve out of it, thats my intention. Improving the project.

Spotless is not able to find these spots as its not spotless itself having no type awareness it seems you need to live with unused imports or cover it with the dedicated recipe what has done the changed offering to merge.

The PR seems to prove that the config it not wrong. But it actually is considering my comment that you ignored. Its not formatting all the java code making the need for some commitment there also.

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.2.0 labels Aug 17, 2025
@Pankraz76
Copy link
Author

Again its not completed as it takes 1H to scan the project. Im not spending this effort if you dont want it. Please let me know. Thank you.

@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Aug 17, 2025
@DaveCTurner
Copy link
Contributor

as requested by @DaveCTurner

No, it wasn't.

Im not spending this effort if you dont want it.

Please don't, thanks.

@elastic elastic locked as resolved and limited conversation to collaborators Aug 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team needs:triage Requires assignment of a team area label v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants