diff --git a/server/src/internalClusterTest/java/org/elasticsearch/repositories/SnapshotMetricsIT.java b/server/src/internalClusterTest/java/org/elasticsearch/repositories/SnapshotMetricsIT.java index 91cf76c6f07e4..b0b1680ce6fb0 100644 --- a/server/src/internalClusterTest/java/org/elasticsearch/repositories/SnapshotMetricsIT.java +++ b/server/src/internalClusterTest/java/org/elasticsearch/repositories/SnapshotMetricsIT.java @@ -276,12 +276,12 @@ public void testByStateCounts_InitAndQueuedShards() throws Exception { assertMetricsHaveAttributes( InstrumentType.LONG_GAUGE, SnapshotMetrics.SNAPSHOT_SHARDS_BY_STATE, - Map.of("project_id", ProjectId.DEFAULT.id(), "repo_name", repositoryName, "repo_type", "mock") + Map.of("repo_name", repositoryName, "repo_type", "mock") ); assertMetricsHaveAttributes( InstrumentType.LONG_GAUGE, SnapshotMetrics.SNAPSHOTS_BY_STATE, - Map.of("project_id", ProjectId.DEFAULT.id(), "repo_name", repositoryName, "repo_type", "mock") + Map.of("repo_name", repositoryName, "repo_type", "mock") ); } @@ -345,12 +345,12 @@ public void testByStateCounts_PausedForRemovalShards() throws Exception { assertMetricsHaveAttributes( InstrumentType.LONG_GAUGE, SnapshotMetrics.SNAPSHOT_SHARDS_BY_STATE, - Map.of("project_id", ProjectId.DEFAULT.id(), "repo_name", repositoryName, "repo_type", "mock") + Map.of("repo_name", repositoryName, "repo_type", "mock") ); assertMetricsHaveAttributes( InstrumentType.LONG_GAUGE, SnapshotMetrics.SNAPSHOTS_BY_STATE, - Map.of("project_id", ProjectId.DEFAULT.id(), "repo_name", repositoryName, "repo_type", "mock") + Map.of("repo_name", repositoryName, "repo_type", "mock") ); } @@ -421,12 +421,12 @@ public void testByStateCounts_WaitingShards() throws Exception { assertMetricsHaveAttributes( InstrumentType.LONG_GAUGE, SnapshotMetrics.SNAPSHOT_SHARDS_BY_STATE, - Map.of("project_id", ProjectId.DEFAULT.id(), "repo_name", repositoryName, "repo_type", "mock") + Map.of("repo_name", repositoryName, "repo_type", "mock") ); assertMetricsHaveAttributes( InstrumentType.LONG_GAUGE, SnapshotMetrics.SNAPSHOTS_BY_STATE, - Map.of("project_id", ProjectId.DEFAULT.id(), "repo_name", repositoryName, "repo_type", "mock") + Map.of("repo_name", repositoryName, "repo_type", "mock") ); } diff --git a/server/src/main/java/org/elasticsearch/repositories/SnapshotMetrics.java b/server/src/main/java/org/elasticsearch/repositories/SnapshotMetrics.java index 9281851d4e6b9..7e818f6e6a27d 100644 --- a/server/src/main/java/org/elasticsearch/repositories/SnapshotMetrics.java +++ b/server/src/main/java/org/elasticsearch/repositories/SnapshotMetrics.java @@ -11,6 +11,7 @@ import org.elasticsearch.cluster.metadata.ProjectId; import org.elasticsearch.cluster.metadata.RepositoryMetadata; +import org.elasticsearch.core.FixForMultiProject; import org.elasticsearch.telemetry.metric.DoubleHistogram; import org.elasticsearch.telemetry.metric.LongCounter; import org.elasticsearch.telemetry.metric.LongWithAttributes; @@ -93,8 +94,8 @@ public void createSnapshotsByStateMetric(Supplier meterRegistry.registerLongsGauge(SNAPSHOTS_BY_STATE, "snapshots by state", "unit", snapshotsByStatusObserver); } + @FixForMultiProject(description = "When multi-project arrives we should add project ID to the labels") public static Map createAttributesMap(ProjectId projectId, RepositoryMetadata meta) { - assert projectId != null : "Project ID should always be set"; - return Map.of("project_id", projectId.id(), "repo_type", meta.type(), "repo_name", meta.name()); + return Map.of("repo_type", meta.type(), "repo_name", meta.name()); } }