Skip to content

Fix release tests for OptimizerVerificationTests #133100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 19, 2025
Merged

Fix release tests for OptimizerVerificationTests #133100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e4bdf8
Fix release tests for OptimizerVerificationTests
smalyshev Aug 19, 2025
ed8b83c
unmute
smalyshev Aug 19, 2025
2f101be
[CI] Auto commit changes from spotless
Aug 19, 2025
da5fd7f
Merge branch 'main' into fix-test-for-release
smalyshev Aug 19, 2025
6ef76f8
Merge branch 'main' into fix-test-for-release
smalyshev Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,9 +585,6 @@ tests:
- class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT
method: test {p0=search/160_exists_query/Test exists query on _id field}
issue: https://github.com/elastic/elasticsearch/issues/133097
- class: org.elasticsearch.xpack.esql.optimizer.OptimizerVerificationTests
method: testRemoteEnrichAfterCoordinatorOnlyPlans
issue: https://github.com/elastic/elasticsearch/issues/133015
- class: org.elasticsearch.xpack.esql.analysis.AnalyzerTests
method: testNoDenseVectorFailsForMagnitude
issue: https://github.com/elastic/elasticsearch/issues/133013
Expand Down
23 changes: 13 additions & 10 deletions ...esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/OptimizerVerificationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import static org.elasticsearch.xpack.esql.analysis.AnalyzerTestUtils.defaultLookupResolution;
import static org.elasticsearch.xpack.esql.analysis.AnalyzerTestUtils.loadEnrichPolicyResolution;
import static org.elasticsearch.xpack.esql.analysis.AnalyzerTestUtils.loadMapping;
import static org.elasticsearch.xpack.esql.plugin.EsqlPlugin.INLINESTATS_FEATURE_FLAG;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.instanceOf;

Expand Down Expand Up @@ -125,16 +126,18 @@ public void testRemoteEnrichAfterCoordinatorOnlyPlans() {
""", analyzer);
assertThat(err, containsString("4:3: ENRICH with remote policy can't be executed after [STATS count(*) BY language_code]@3:3"));

err = error("""
FROM test
| EVAL language_code = languages
| INLINESTATS count(*) BY language_code
| ENRICH _remote:languages ON language_code
""", analyzer);
assertThat(
err,
containsString("4:3: ENRICH with remote policy can't be executed after [INLINESTATS count(*) BY language_code]@3:3")
);
if (INLINESTATS_FEATURE_FLAG) {
err = error("""
FROM test
| EVAL language_code = languages
| INLINESTATS count(*) BY language_code
| ENRICH _remote:languages ON language_code
""", analyzer);
assertThat(
err,
containsString("4:3: ENRICH with remote policy can't be executed after [INLINESTATS count(*) BY language_code]@3:3")
);
}

err = error("""
FROM test
Expand Down