Remove docID check from BlockDocValuesReader #133101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
martijnvg
approved these changes
Aug 19, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM, thx Nhat. I was wondering why these checks were necessary given that all doc value implementations need to keep track of current docid in order to work correctly.
Member
Author
|
Yes, we may wrap our custom implementation with AssertingNumericDocValues when assertions are enabled. |
Member
Author
|
Thanks Martijn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that our DocValues extensions track docId correctly; therefore, I think we can remove the extra docId tracking from BlockDocValuesReader.