Use expectedDocs instead of actualDocs to stop posting lists iteration #133116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #132722, we change the condition to stop the iteration of posting lists tot ake into account the number of documents visited instead of the number of posting lists. The condition was changed to take into account the number of scored docs.
This had a side effect because now in the case of a search with a filter we are visiting much more posting lists because we don't stop until we visit a non-filtered number of documents where before this was not taking into account. Ic hecked and I think the current check is wrong as we are visiting too many documents and the condition should be using expectedDocs so we bail out when we reach that number and we collected enough documents.
running a filtered search in main:
With this PR: