Add separate validation for unreferenced transport version definitions #133189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits out the validation that is pertinent to unreferenced definitions. It also adds validation that names of named and unreferenced definitions cannot collide.
rjernst
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
JVerwolf
approved these changes
Aug 20, 2025
| "[myserver/src/main/resources/transport/definitions/unreferenced/existing_92.csv]") | ||
| } | ||
|
|
||
| def "unreferenced definitions can have primary ids that are patches"() { |
Contributor
There was a problem hiding this comment.
I'm curious, why? These are created when a new branch is cut, which will result in a "base id" without a patch section, right? Is there another scenario where a patch is needed?
Contributor
There was a problem hiding this comment.
Yes. We bump the transport version on every release. So when we release 9.2.0 and bump the version to 9.2.1, we also bump the transport version, which in that case would be a patch version. This is to ensure that every stack version has a unique transport version.
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 20, 2025
elastic#133189) This commit splits out the validation that is pertinent to unreferenced definitions. It also adds validation that names of named and unreferenced definitions cannot collide.
This was referenced Aug 20, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 20, 2025
This commit backports several changes to the new transport version system relates elastic#133034 relates elastic#133185 relates elastic#133186 relates elastic#133189
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 20, 2025
This commit backports several changes to the new transport version system relates elastic#133034 relates elastic#133185 relates elastic#133186 relates elastic#133189
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 20, 2025
This commit backports several changes to the new transport version system relates elastic#133034 relates elastic#133185 relates elastic#133186 relates elastic#133189
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Replace transport version utils with a build service (#133034) Several transport version build tasks have a need to access the repository-wide transport version resources. Thus far it has been done through several utility methods. This commit moves these utility methods into an encapsulated build service that is shared across the transport version tasks. The advantage is that no paths are used, the build service encapsulates access to the resources and understands internally how to find the correct filesystem path and load it. * Make transport version ids have descending ordering (#133185) Transport version ids must be in descending order in definition files. However, the compareTo for them was ascending and the validation used reverse ordering. This commit fixes the compareTo so it uses desending ordering and the validation uses natural ordering. * Fix transport version validation task name (#133186) The task class validates resources, but the task name still had the old "definitions" suffix. * Add separate validation for unreferenced transport version definitions (#133189) This commit splits out the validation that is pertinent to unreferenced definitions. It also adds validation that names of named and unreferenced definitions cannot collide. * Use path separator for git path in transport resources (#133228) When looking up files from main in transport resources, the system dependent path is used. However, the beginning slash also needs to be system dependent.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Backport several transport version fixes This commit backports several changes to the new transport version system relates #133034 relates #133185 relates #133186 relates #133189 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Backport several transport version fixes This commit backports several changes to the new transport version system relates #133034 relates #133185 relates #133186 relates #133189 * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 23, 2025
This commit backports several changes to the new transport version system relates #133034 relates #133185 relates #133186 relates #133189 Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits out the validation that is pertinent to unreferenced definitions. It also adds validation that names of named and unreferenced definitions cannot collide.