Skip to content

Fix offset handling in Murmur3Hasher #133193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixbarny merged 2 commits into from
Aug 20, 2025
Merged

Fix offset handling in Murmur3Hasher #133193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b284b1d
Fix offset handling in Murmur3Hasher
felixbarny Aug 20, 2025
a7fbb50
Update docs/changelog/133193.yaml
felixbarny Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/133193.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 133193
summary: Fix offset handling in Murmur3Hasher
area: Infra/Core
type: bug
issues: []
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/common/hash/Murmur3Hasher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public void update(byte[] inputBytes, int offset, int length) {
System.arraycopy(inputBytes, offset + numBytesToHash, remainder, 0, remainderLength);
}
} else {
System.arraycopy(inputBytes, 0, remainder, remainderLength, length);
System.arraycopy(inputBytes, offset, remainder, remainderLength, length);
remainderLength += length;
}
}
Expand Down
6 changes: 5 additions & 1 deletion server/src/test/java/org/elasticsearch/common/hashing/Murmur3HasherTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,12 @@ private static void assertHash(long lower, long upper, String inputString, long
expected.h2 = upper;

byte[] bytes = inputString.getBytes(StandardCharsets.UTF_8);
int padding = randomInt(8);
int offset = randomInt(padding);
byte[] paddedBytes = new byte[bytes.length + padding];
System.arraycopy(bytes, 0, paddedBytes, offset, bytes.length);
Murmur3Hasher mh = new Murmur3Hasher(seed);
mh.update(bytes);
mh.update(paddedBytes, offset, bytes.length);
MurmurHash3.Hash128 actual = mh.digestHash();
assertHash(expected, actual);
}
Expand Down