Remove track_postings_in_memory_bytes feature flag #133583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
elasticsearchmachine
added
the
serverless-linked
…ory-bytes-remove-ff
martijnvg
approved these changes
Aug 27, 2025
| public ShardFieldStats shardFieldStats() { | ||
| try (var searcher = acquireSearcher("shard_field_stats", Engine.SearcherScope.INTERNAL)) { | ||
| return shardFieldStats(searcher.getLeafContexts()); | ||
| boolean isStateless = DiscoveryNode.isStateless(engineConfig.getIndexSettings().getNodeSettings()); |
There was a problem hiding this comment.
Can we turn this into a field in Engine? Then there is no need to read the node settings every time this method gets invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #129969 to remove the feature flag.