Execute single shard each pipeline for rate #133610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>non-issue
:StorageEngine/TSDB
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Thanks Martijn! |
|
LGTM, looking fwd to see the impact. |
kkrik-es
reviewed
Aug 27, 2025
| if (p.operators().stream().anyMatch(s -> s.status() instanceof TimeSeriesSourceOperator.Status)) { | ||
| assertThat(p.operators(), hasSize(2)); | ||
| TimeSeriesSourceOperator.Status status = (TimeSeriesSourceOperator.Status) p.operators().get(0).status(); | ||
| assertThat(status.processedShards(), hasSize(1)); |
There was a problem hiding this comment.
I saw a failure in my PR:
REPRODUCE WITH: ./gradlew ":x-pack:plugin:esql:internalClusterTest" --tests "org.elasticsearch.xpack.esql.action.TimeSeriesIT.testProfile" -Dtests.seed=ADBEEDF1C962A1C8 -Dtests.locale=nso -Dtests.timezone=Europe/Samara -Druntime.java=24
--
| 2> java.lang.AssertionError:
| Expected: a collection with size <1>
| but: collection size was <0>
| at __randomizedtesting.SeedInfo.seed([ADBEEDF1C962A1C8:FCE458746D2F19E1]:0)
| at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
| at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
| at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2706)
| at org.elasticsearch.xpack.esql.action.TimeSeriesIT.testProfile(TimeSeriesIT.java:556)
There was a problem hiding this comment.
Thanks Kostas! I will look into it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each pipeline in rate aggregation, we use 3 drivers and execute one shard at a time; therefore, the maximum parallelism per query on data nodes is 3. Unlike non-rate aggregations, we cannot partition shards into multiple slices for concurrent execution, which is one of several limitations of rate aggregation. These changes adjust the data node executor to run multiple pipelines simultaneously, with each pipeline handling a single shard to increase parallelism when there are multiple target shards on data nodes.
This change is expected to improve benchmark by 3 times.