Skip to content

Update WriteLoadConstraintSetting defaults #133617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicktindall merged 3 commits into from
Aug 27, 2025
Merged

Update WriteLoadConstraintSetting defaults #133617

nicktindall merged 3 commits into from
Aug 27, 2025

Conversation

@nicktindall
Copy link
Contributor

@nicktindall nicktindall commented Aug 27, 2025 •
edited
Loading

This PR makes some tweaks to the WriteLoadConstraintSettings

  • Change default queue latency threshold to 10s, experiments so far seem to indicate that 10s is a better default than 30s.
  • Change default reroute interval to 0s, we are happy to rely on the ClusterInfo polling interval to sufficiently space these calls
  • Remove shard write load calculation interval, this is redundant because we leverage the write loads implemented for auto-sharding

@nicktindall nicktindall added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Aug 27, 2025
@elasticsearchmachine elasticsearchmachine added Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0 labels Aug 27, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 27, 2025

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@nicktindall nicktindall mentioned this pull request Aug 27, 2025
Merged
@nicktindall nicktindall requested a review from a team as a code owner August 27, 2025 02:06
@nicktindall nicktindall changed the title Reduce default queue-latency threshold to 10s Update WriteLoadConstraintSetting defaults Aug 27, 2025
DiannaHohensee
DiannaHohensee approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@DiannaHohensee DiannaHohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicktindall nicktindall merged commit 2e8507f into elastic:main Aug 27, 2025
33 checks passed
@nicktindall nicktindall deleted the reduce_default_queue_latency_treshold branch September 3, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd left review comments

@DiannaHohensee DiannaHohensee DiannaHohensee approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicktindall @elasticsearchmachine @ywangd @DiannaHohensee