[ESQL] Fix some illegal polygons in test data #133640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
craigtaverner
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
We could have just removed the illegal holes, but for this test data it is certainly fine to remove all holes. I did a little investigation and it seems that the PostGIS function I used to generate these ST_SimplifyPreserveTopology, was not seeing the holes as invalid if they did not cross edges with the shell. This seems to be a limitation or issue with PostGIS (or the underlying GEOS library used for this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These polygons contain illegal holes that are outside of the actual polygon. Let's fix them as they will fail in the next lucene version.