Skip to content

ES|QL: Fix CsvTests to not break randomized tests #133643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

ES|QL: Fix CsvTests to not break randomized tests #133643

merged 1 commit into from
Aug 27, 2025

Conversation

@leontyevdv
Copy link
Contributor

One of the tests for the tbucket function fails due to the random order of the results.

It can be reproduced by the following command:

./gradlew ":x-pack:plugin:esql:qa:server:mixed-cluster:bcUpgradeTest" -Dtests.class="org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT" -Dtests.method="test {csv-spec:union_types.MultiIndexTBucketGroupingAndAggregation}" -Dtests.seed=6FDF997729FCF32C -Dtests.bwc.main.version=9.2.0-SNAPSHOT -Dtests.bwc.refspec.main=54a24728971697d3f7af2d13fd33412d9f7dc145 -Dtests.locale=jv-ID -Dtests.timezone=MIT -Druntime.java=24

@leontyevdv leontyevdv self-assigned this Aug 27, 2025
@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label labels Aug 27, 2025
@leontyevdv leontyevdv added >test Issues or PRs that are addressing/adding tests :StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL :StorageEngine/TSDB You know, for Metrics and removed needs:triage Requires assignment of a team area label v9.2.0 labels Aug 27, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@leontyevdv leontyevdv merged commit b23e2e7 into elastic:main Aug 27, 2025
33 checks passed
@leontyevdv leontyevdv added v9.2.0 and removed v9.0.2 labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkrik-es kkrik-es kkrik-es approved these changes

@not-napoleon not-napoleon Awaiting requested review from not-napoleon

@gmarouli gmarouli Awaiting requested review from gmarouli

Assignees

@leontyevdv leontyevdv

Labels

:StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leontyevdv @elasticsearchmachine @kkrik-es