Skip to content

Fix TimeSeriesIT#testProfile #133668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnhatn merged 1 commit into from
Aug 27, 2025
Merged

Fix TimeSeriesIT#testProfile #133668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,9 +648,6 @@ tests:
- class: org.elasticsearch.compute.data.BasicBlockTests
method: testFloatBlock
issue: https://github.com/elastic/elasticsearch/issues/133621
- class: org.elasticsearch.xpack.esql.action.TimeSeriesIT
method: testProfile
issue: https://github.com/elastic/elasticsearch/issues/133624

# Examples:
#
Expand Down
7 changes: 5 additions & 2 deletions ...n/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/TimeSeriesIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import static org.elasticsearch.index.mapper.DateFieldMapper.DEFAULT_DATE_TIME_FORMATTER;
import static org.hamcrest.Matchers.closeTo;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.either;
import static org.hamcrest.Matchers.empty;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasSize;
Expand Down Expand Up @@ -553,7 +554,9 @@ public void testProfile() {
if (p.operators().stream().anyMatch(s -> s.status() instanceof TimeSeriesSourceOperator.Status)) {
assertThat(p.operators(), hasSize(2));
TimeSeriesSourceOperator.Status status = (TimeSeriesSourceOperator.Status) p.operators().get(0).status();
assertThat(status.processedShards(), hasSize(1));
// If the target shard is empty or does not match the query, processedShards will be empty.
// TODO: Update ComputeService to avoid creating pipelines for non-matching or empty shards.
assertThat(status.processedShards(), either(hasSize(1)).or(empty()));
assertThat(p.operators().get(1).operator(), equalTo("ExchangeSinkOperator"));
} else if (p.operators().stream().anyMatch(s -> s.status() instanceof TimeSeriesAggregationOperator.Status)) {
assertThat(p.operators(), hasSize(3));
Expand Down Expand Up @@ -587,7 +590,7 @@ public void testProfile() {
assertThat(ops.get(0).operator(), containsString("LuceneSourceOperator"));
assertThat(ops.get(0).status(), Matchers.instanceOf(LuceneSourceOperator.Status.class));
LuceneSourceOperator.Status status = (LuceneSourceOperator.Status) ops.get(0).status();
assertThat(status.processedShards(), hasSize(3));
assertThat(status.processedShards().size(), Matchers.lessThanOrEqualTo(3));
assertThat(ops.get(1).operator(), containsString("EvalOperator"));
assertThat(ops.get(2).operator(), containsString("ValuesSourceReaderOperator"));
assertThat(ops.get(3).operator(), containsString("TimeSeriesAggregationOperator"));
Expand Down