ESQL: Patch kibana signature for BUCKET #133682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our signature handling code considers the second and third arguments of BUCKET to be optional - the railroad diagram and function registry consider those arguments optional. But in another sense, these function arguments aren't optional - they are required IF you are invoking the certain types. This patches the generated kibana signature to it'll look and feel right.
elasticsearchmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/core-docs (Team:Docs) |
drewdaemon
approved these changes
Aug 28, 2025
Contributor
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Amazing. Thank you @nik9000 !
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
Our signature handling code considers the second and third arguments of BUCKET to be optional - the railroad diagram and function registry consider those arguments optional. But in another sense, these function arguments aren't optional - they are required IF you are invoking the certain types. This patches the generated kibana signature to it'll look and feel right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our signature handling code considers the second and third arguments of BUCKET to be optional - the railroad diagram and function registry consider those arguments optional.
But in another sense, these function arguments aren't optional - they are required IF you are invoking the certain types.
This patches the generated kibana signature to it'll look and feel right.
Closes #132592