- 
                Notifications
    You must be signed in to change notification settings 
- Fork 25.6k
          Supporting more timestamp formats in _text_structure/find_structure
          #133745
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            eyalkoren
  merged 15 commits into
  elastic:main
from
eyalkoren:supporting-more-timestamp-formats
  
      
      
   
  Sep 2, 2025 
      
    
                
     Merged
            
            
  
    Supporting more timestamp formats in _text_structure/find_structure
  
  #133745
              
                    eyalkoren
  merged 15 commits into
  elastic:main
from
eyalkoren:supporting-more-timestamp-formats
  
      
      
   
  Sep 2, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Pinging @elastic/ml-core (Team:ML) | 
| Hi @eyalkoren, I've created a changelog YAML for you. | 
              
                    jan-elastic
  
              
              approved these changes
              
                  
                    Sep 2, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
        
          
                ...t/java/org/elasticsearch/xpack/textstructure/structurefinder/TimestampFormatFinderTests.java
          
            Show resolved
            Hide resolved
        
      …mats' into supporting-more-timestamp-formats
| @jan-elastic Thanks for the quick review 🙏 | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Adding support for additional timestamps in the
_text_structure/find_structureendpoint.Added formats are tested through unit tests and REST API tests.