Assert in IndexReshardingState.Split ctor that source shards are not … #134229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxie-1
added
>non-issue
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Contributor
Author
elasticsearchmachine
added
the
serverless-linked
lkts
approved these changes
Sep 5, 2025
Contributor
Author
|
Actually some unit tests are failing, do we want to change this? |
ankikuma
approved these changes
Sep 10, 2025
Contributor
I think it's fairly easy to adjust that test to take into account the invariant we've introduced. |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
elastic#134229) * Assert in IndexReshardingState.Split ctor that source shards are not all done * Fix reshard unit tests * Remove reshard state inProgress method
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
elastic#134229) * Assert in IndexReshardingState.Split ctor that source shards are not all done * Fix reshard unit tests * Remove reshard state inProgress method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an assert as suggested in https://github.com/elastic/elasticsearch-serverless/pull/4461
The last source shard to complete will remove reshard metadata, so there should always be at least one source shard not done