Add pull request job to verify transport versions backported via main #134568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
force-pushed
the
transport-version-backport-validation
branch
from
2fb9b0c to
bfb97cf
Compare
rjernst
approved these changes
Sep 12, 2025
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
Looks good, just minor questions/comments
|
|
||
| # Get any changes in this pull request to transport definitions | ||
| git fetch origin "${BUILDKITE_PULL_REQUEST_BASE_BRANCH}" --quiet | ||
| changed_files=$(git diff --name-only "origin/${BUILDKITE_PULL_REQUEST_BASE_BRANCH}" | grep -E "server/src/main/resources/transport/definitions/.*\.csv" || true) |
Member
There was a problem hiding this comment.
what does the "or true" do? Won't that make changed_files a boolean instead of a string list of changes?
Contributor
Author
There was a problem hiding this comment.
the || true just ensures we always return a 0 exit code from that command since we have set pipefail. Otherwise if grep doesn't return any matches, we'll exit with a non-zero exit code, failing the job, which isn't what we want.
Contributor
Author
There was a problem hiding this comment.
To further clarify, the true utility doesn't produce any output. It simply always returns a 0 exit code. So in that scenario changed_files is still an empty string if there are no matches.
This reverts commit 249b64e.
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 12, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 12, 2025
This was referenced Sep 12, 2025
Merged
Collaborator
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 12, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Sep 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 12, 2025
mark-vieira
added a commit
that referenced
this pull request
Sep 13, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Sep 17, 2025
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This registers a new PR job that ensures that any changes to transport versions to backport branches are also present in the
mainbranch. This check does not run on themainbranch itself.