Add BytesStreamOutputTests #134788
Merged
Add BytesStreamOutputTests #134788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-adams-1
added
>non-issue
:Distributed Coordination/Distributed
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
joshua-adams-1
added
>test
DiannaHohensee
approved these changes
Sep 26, 2025
server/src/test/java/org/elasticsearch/common/io/stream/BytesStreamOutputTests.java
Show resolved
Hide resolved
| byte[] byteArray = randomByteArrayOfLength(byteArrayLength); | ||
| stream.writeBytes(byteArray, 0, byteArrayLength); | ||
|
|
||
| int seekPosition = randomIntBetween(byteArrayLength, byteArrayLength + 100); |
There was a problem hiding this comment.
IIUC, a seek could be done to somewhere between 0 and byteArrayLength, and then a read can be done to show that it matches the byteArray? Same thing with skip below, though the seek would have to be further constrained to leave some room to test skip on the data set.
Would that be more realistic than setting the read position into space that hasn't been written yet? Or maybe test both?
DiannaHohensee
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing #133558 I adopted an approach that utilised
BytesStreamOutputand I wrote a unit test suite. Subsequent refactors have removed the need to use this class, but I still believe there is value in having theBytesStreamOutputTestssuite.Testing
I have ran this test suite through a 10000 times, and it all succeeds