[8.19] [ML] Do not convert input Strings to ChunkInferenceInput unless necessary (#134945) #135291
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sary (elastic#134945) The SenderService.infer() method was converting the input variable from a List<String> into a List<ChunkInferenceInput>, but then when that list was passed into SenderService.createInput() it was immediately converted back into a List<String>. To avoid unnecessary work, allow the EmbeddingsInput constructor to convert the list if necessary. (cherry picked from commit 8d2c4c3)
DonalEvans
added
backport
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will backport the following commits from main to 8.19:
The SenderService.infer() method was converting the input variable from a List into a List, but then when that list was passed into SenderService.createInput() it was immediately converted back into a List. To avoid unnecessary work, allow the EmbeddingsInput constructor to convert the list if necessary.
(cherry picked from commit 8d2c4c3)