diff --git a/build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/TransportVersionGenerationFuncTest.groovy b/build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/TransportVersionGenerationFuncTest.groovy index cda7fc665782c..d1ca9eae48b97 100644 --- a/build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/TransportVersionGenerationFuncTest.groovy +++ b/build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/TransportVersionGenerationFuncTest.groovy @@ -90,6 +90,9 @@ class TransportVersionGenerationFuncTest extends AbstractTransportVersionFuncTes assertUpperBound("9.2", "new_tv,8124000") } + /* + temporarily muted, see https://github.com/elastic/elasticsearch/pull/135226 + def "invalid changes to a upper bounds should be reverted"() { given: transportVersionUpperBound("9.2", "modification", "9000000") @@ -144,7 +147,7 @@ class TransportVersionGenerationFuncTest extends AbstractTransportVersionFuncTes assertReferableDefinitionDoesNotExist("test_tv") assertUpperBound("9.2", "existing_92,8123000") assertUpperBound("9.1", "existing_92,8012001") - } + }*/ def "a reference can be renamed"() { given: @@ -242,8 +245,11 @@ class TransportVersionGenerationFuncTest extends AbstractTransportVersionFuncTes def "unreferenced definitions are removed"() { given: referableTransportVersion("test_tv", "8124000,8012002") + /* + TODO: reset of upper bounds transportVersionUpperBound("9.2", "test_tv", "8124000") transportVersionUpperBound("9.1", "test_tv", "8012002") + */ when: def result = runGenerateAndValidateTask().build() @@ -477,6 +483,8 @@ class TransportVersionGenerationFuncTest extends AbstractTransportVersionFuncTes assertUpperBound("9.2", "new_tv,8124000") } + /* + TODO: reset of upper bounds def "deleted upper bounds files are restored"() { given: file("myserver/src/main/resources/transport/upper_bounds/9.2.csv").delete() @@ -487,7 +495,7 @@ class TransportVersionGenerationFuncTest extends AbstractTransportVersionFuncTes then: assertGenerateAndValidateSuccess(result) assertUpperBound("9.2", "existing_92,8123000") - } + }*/ def "upper bounds files must exist for backport branches"() { when: diff --git a/build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/GenerateTransportVersionDefinitionTask.java b/build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/GenerateTransportVersionDefinitionTask.java index 7d5baa1b5fc64..f0d910730dce9 100644 --- a/build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/GenerateTransportVersionDefinitionTask.java +++ b/build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/GenerateTransportVersionDefinitionTask.java @@ -107,7 +107,8 @@ public void run() throws IOException { getLogger().lifecycle("Generating transport version name: " + targetDefinitionName); if (targetDefinitionName.isEmpty()) { - resetAllUpperBounds(resources); + // TODO: resetting upper bounds needs to be done locally, otherwise it pulls in some (incomplete) changes from upstream main + // resetAllUpperBounds(resources); } else { List ids = updateUpperBounds(resources, upstreamUpperBounds, targetUpperBoundNames, targetDefinitionName); // (Re)write the definition file.