-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adding docs-producing tests for delta, idelta, increase, irate #135490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/core-docs (Team:Docs) |
886c113 to
a32b41d
Compare
c3e04ef to
1b2faab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed couple things driving by here :)
| **Example** | ||
|
|
||
| ```esql | ||
| null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
|
|
||
| ## `DELTA` [esql-delta] | ||
| ```{applies_to} | ||
| stack: unavailable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these functions needs to have the correct version info
stack: preview|ga 9.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#134373 addresses this, please sync and rerun tests to regen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabloem delta still has stack:unavailable while the others have been updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops added!
1b2faab to
f0610d7
Compare
f0610d7 to
b46303b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delta still has incorrect version info and the examples are null for all 4 functions. We can't have null examples per #135094.
Maybe just need to merge main at this point and regenerate, not sure :)
|
|
||
| ## `DELTA` [esql-delta] | ||
| ```{applies_to} | ||
| stack: unavailable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabloem delta still has stack:unavailable while the others have been updated
...gin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/aggregate/Delta.java
Outdated
Show resolved
Hide resolved
docs/reference/query-languages/esql/_snippets/functions/examples/delta.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some smaller comments, but LGTM. Thanks @pabloem
Adding tests that validate functionality of new esql functions. These tests, upon passing, generated markdown and other files of documentation that are included for kibana and es.