Skip to content

Conversation

@pabloem
Copy link
Contributor

@pabloem pabloem commented Sep 25, 2025

Adding tests that validate functionality of new esql functions. These tests, upon passing, generated markdown and other files of documentation that are included for kibana and es.

@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label labels Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

@github-actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@pabloem pabloem added >docs General docs changes >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics Team:StorageEngine and removed needs:triage Requires assignment of a team area label labels Sep 25, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Sep 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed couple things driving by here :)

**Example**

```esql
null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a null example will break Kibana, @ioanatia just added a check for this in #135094

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!


## `DELTA` [esql-delta]
```{applies_to}
stack: unavailable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these functions needs to have the correct version info

stack: preview|ga 9.2.0

see https://github.com/elastic/elasticsearch/tree/main/docs/reference/query-languages/esql#version-differentiation-in-docs-v3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#134373 addresses this, please sync and rerun tests to regen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem delta still has stack:unavailable while the others have been updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops added!

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delta still has incorrect version info and the examples are null for all 4 functions. We can't have null examples per #135094.

Maybe just need to merge main at this point and regenerate, not sure :)


## `DELTA` [esql-delta]
```{applies_to}
stack: unavailable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem delta still has stack:unavailable while the others have been updated

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some smaller comments, but LGTM. Thanks @pabloem

@pabloem pabloem enabled auto-merge (squash) September 30, 2025 22:54
@pabloem pabloem merged commit 9afd217 into elastic:main Sep 30, 2025
34 checks passed
@pabloem pabloem deleted the pem-docstests branch September 30, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :StorageEngine/TSDB You know, for Metrics Team:Docs Meta label for docs team Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants