Refactor CrossProjectIndexExpressionsRewriter
#135588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>non-issue
:Security/Security
n1v0lg
commented
Sep 29, 2025
| this(localExpression, List.of()); | ||
| } | ||
|
|
||
| List<String> all() { |
There was a problem hiding this comment.
This will disappear once we've removed public static Map<String, List<String>> rewriteIndexExpressions in favor of calling rewriteIndexExpression inside the IndexAbstractionResolver
n1v0lg
changed the title
CrossProjectSearchIndexExpressionRewriterCrossProjectIndexExpressionRewriter
n1v0lg
changed the title
CrossProjectIndexExpressionRewriterCrossProjectIndexExpressionsRewriter
|
Pinging @elastic/es-security (Team:Security) |
|
serverless failure is unrelated |
n1v0lg
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring pass over
CrossProjectIndexExpressionsRewriterto make it plug into the end-to-end expression rewriting flow (#135346).The main change is isolating the logic of rewriting a single expression into
rewriteIndexExpression. Also, fixes two smaller quirks:"*"we rewrite to_all. There is a marginal difference in behavior between the two and_allbetter matches empty index expression behavior