Simplify TextSearchInfo handling in MappedFieldType #135617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority of field types use TextSearchInfo.NONE, and most of the rest extend TermBasedFieldType. Rather than forcing all field types to include TextSearchInfo as part of a constructor call, we instead have a default method on the base class, a constructor parameter for TermBasedFieldType, and method overrides for the few field types left over.
romseygeek
added
>non-issue
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
elasticsearchmachine
added
the
serverless-linked
romseygeek
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vast majority of field types use TextSearchInfo.NONE, and most of the rest
extend TermBasedFieldType. Rather than forcing all field types to include
TextSearchInfo as part of a constructor call, we instead have a default method
on the base class, a constructor parameter for TermBasedFieldType, and method
overrides for the few field types left over.