Skip to content

Serialize ReplicationRequest reshard shardcount summary as VInt instead of Int #135648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
+16 −8
Merged

Serialize ReplicationRequest reshard shardcount summary as VInt instead of Int #135648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions server/src/main/java/org/elasticsearch/action/support/replication/ReplicationRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ public abstract class ReplicationRequest<Request extends ReplicationRequest<Requ
implements
IndicesRequest {

// superseded
private static final TransportVersion INDEX_RESHARD_SHARDCOUNT_SUMMARY = TransportVersion.fromName("index_reshard_shardcount_summary");
// bumped to use VInt instead of Int
private static final TransportVersion INDEX_RESHARD_SHARDCOUNT_SMALL = TransportVersion.fromName("index_reshard_shardcount_small");

public static final TimeValue DEFAULT_TIMEOUT = TimeValue.timeValueMinutes(1);

Expand Down Expand Up @@ -126,14 +129,16 @@ public ReplicationRequest(@Nullable ShardId shardId, int reshardSplitShardCountS
index = in.readString();
}
routedBasedOnClusterVersion = in.readVLong();
if (in.getTransportVersion().supports(INDEX_RESHARD_SHARDCOUNT_SUMMARY)) {
if (thinRead) {
this.reshardSplitShardCountSummary = reshardSplitShardCountSummary;
} else {
if (thinRead) {
this.reshardSplitShardCountSummary = reshardSplitShardCountSummary;
} else {
if (in.getTransportVersion().supports(INDEX_RESHARD_SHARDCOUNT_SMALL)) {
this.reshardSplitShardCountSummary = in.readVInt();
} else if (in.getTransportVersion().supports(INDEX_RESHARD_SHARDCOUNT_SUMMARY)) {
this.reshardSplitShardCountSummary = in.readInt();
} else {
this.reshardSplitShardCountSummary = 0;
}
} else {
this.reshardSplitShardCountSummary = 0;
}
}

Expand Down Expand Up @@ -262,7 +267,9 @@ public void writeTo(StreamOutput out) throws IOException {
out.writeTimeValue(timeout);
out.writeString(index);
out.writeVLong(routedBasedOnClusterVersion);
if (out.getTransportVersion().supports(INDEX_RESHARD_SHARDCOUNT_SUMMARY)) {
if (out.getTransportVersion().supports(INDEX_RESHARD_SHARDCOUNT_SMALL)) {
out.writeVInt(reshardSplitShardCountSummary);
} else if (out.getTransportVersion().supports(INDEX_RESHARD_SHARDCOUNT_SUMMARY)) {
out.writeInt(reshardSplitShardCountSummary);
}
}
Expand Down
1 change: 1 addition & 0 deletions server/src/main/resources/transport/definitions/referable/index_reshard_shardcount_small.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
9181000
2 changes: 1 addition & 1 deletion server/src/main/resources/transport/upper_bounds/9.2.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
elastic_reranker_chunking_configuration,9180000
index_reshard_shardcount_small,9181000