Skip to content

Conversation

@gmarouli
Copy link
Contributor

@gmarouli gmarouli commented Sep 30, 2025

In this PR we introduce a mapping metadata field that allows us to skip the force-merge request during a downsamping API request.

When an index has the downsample.forcemerge.enabled in their mapping metadata, they can enable or disable the force merge:

{
  "_meta": {
      "downsample.forcemerge.enabled": false
  }
}

By default, force merge is enabled to match the current user experience.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two questions looks good otherwise 👍

@gmarouli gmarouli added >non-issue :StorageEngine/Downsampling Downsampling (replacement for rollups) - Turn fine-grained time-based data into coarser-grained data labels Sep 30, 2025
@gmarouli gmarouli marked this pull request as ready for review September 30, 2025 12:51
@gmarouli gmarouli added auto-backport Automatically create backport pull requests when merged v8.19.5 v9.1.5 labels Sep 30, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@gmarouli gmarouli requested a review from martijnvg September 30, 2025 12:52
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmarouli gmarouli added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 30, 2025
@elasticsearchmachine elasticsearchmachine merged commit 51eaf4b into elastic:main Sep 30, 2025
35 checks passed
@gmarouli gmarouli deleted the disable-downsampling-force-merge-via-mapping branch September 30, 2025 17:56
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 135694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :StorageEngine/Downsampling Downsampling (replacement for rollups) - Turn fine-grained time-based data into coarser-grained data Team:StorageEngine v8.19.5 v9.1.5 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants