From a7959ae997e0d707af3cdc1bc9e95bfcdd19e0e3 Mon Sep 17 00:00:00 2001 From: David Kyle Date: Mon, 6 Oct 2025 13:05:55 +0100 Subject: [PATCH 1/2] Model Id is required --- .../xpack/inference/services/cohere/CohereService.java | 2 +- .../xpack/inference/services/cohere/CohereServiceTests.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java index f1e34138aad5c..b61274ac28672 100644 --- a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java +++ b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/cohere/CohereService.java @@ -378,7 +378,7 @@ public static InferenceServiceConfiguration get() { "The name of the model to use for the inference task." ) .setLabel("Model ID") - .setRequired(false) + .setRequired(true) .setSensitive(false) .setUpdatable(false) .setType(SettingsConfigurationFieldType.STRING) diff --git a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java index d3f00e9c06c5e..0f897500698ee 100644 --- a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java +++ b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceTests.java @@ -1556,7 +1556,7 @@ public void testGetConfiguration() throws Exception { "model_id": { "description": "The name of the model to use for the inference task.", "label": "Model ID", - "required": false, + "required": true, "sensitive": false, "updatable": false, "type": "str", From b43eebe713dcc2975024c5e9f5eb7156410878a6 Mon Sep 17 00:00:00 2001 From: David Kyle Date: Mon, 6 Oct 2025 13:11:39 +0100 Subject: [PATCH 2/2] Update docs/changelog/136017.yaml --- docs/changelog/136017.yaml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 docs/changelog/136017.yaml diff --git a/docs/changelog/136017.yaml b/docs/changelog/136017.yaml new file mode 100644 index 0000000000000..75ecbccf243cf --- /dev/null +++ b/docs/changelog/136017.yaml @@ -0,0 +1,5 @@ +pr: 136017 +summary: Cohere service Model Id field is required +area: Machine Learning +type: bug +issues: []