Random sampling get stats #136040
Open
Random sampling get stats #136040
+803
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Ingest Node
…icsearch into random-sampling-get-stats
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new REST action and corresponding transport action for fetching statistics about random sampling data. The implementation enables users to retrieve statistics about sampling operations performed on indices through a new /_sample/stats endpoint.
Key changes:
- Added a new
GetSampleStatsActionwith REST and transport handlers for retrieving sampling statistics - Updated the
SamplingService.SampleStatsclass to improve field naming, add test constructors, and enhance human-readable time representations - Added comprehensive test coverage for the new action classes and serialization
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
server/src/main/java/org/elasticsearch/action/admin/indices/sampling/GetSampleStatsAction.java |
Core action definition with request/response classes for sampling statistics |
server/src/main/java/org/elasticsearch/action/admin/indices/sampling/RestGetSampleStatsAction.java |
REST handler implementing the /{index}/_sample/stats endpoint |
server/src/main/java/org/elasticsearch/action/admin/indices/sampling/TransportGetSampleStatsAction.java |
Transport layer implementation for sampling statistics retrieval |
server/src/main/java/org/elasticsearch/ingest/SamplingService.java |
Enhanced SampleStats class with improved field naming and test support |
server/src/main/java/org/elasticsearch/action/ActionModule.java |
Registration of new action and REST handler |
| Various test files | Comprehensive test coverage for serialization and functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server/src/main/java/org/elasticsearch/action/admin/indices/sampling/GetSampleStatsAction.java
Outdated
Show resolved
Hide resolved
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
reviewed
Oct 6, 2025
.../src/main/java/org/elasticsearch/action/admin/indices/sampling/RestGetSampleStatsAction.java
Outdated
Show resolved
Hide resolved
...main/java/org/elasticsearch/action/admin/indices/sampling/TransportGetSampleStatsAction.java
Outdated
Show resolved
Hide resolved
seanzatzdev
approved these changes
Oct 7, 2025
| * cloned copy of the stats, but with the reported samples lowered to maxSize, and the reported rejected documents increased by the | ||
| * same amount. This avoids the confusing situation of the stats reporting more samples than the user has configured. | ||
| */ | ||
| public SampleStats adjustForMaxSize(int maxSize) { |
There was a problem hiding this comment.
This avoids the confusing situation of the stats reporting more samples than the user has configured
Nit, feel free to ignore; I'd just say we may want to add to the comment here on why this may occur (needing to reconcile the results from across different nodes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new rest action and corresponding transport action for fetching stats about a random sample.