Cuvs snapshot update #136057
Merged
Cuvs snapshot update #136057
+85
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayya-sharipova
added
auto-backport
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
ldematte
reviewed
Oct 7, 2025
x-pack/plugin/gpu/src/main/java/org/elasticsearch/xpack/gpu/codec/DatasetUtilsImpl.java
Outdated
Show resolved
Hide resolved
ldematte
approved these changes
Oct 7, 2025
| CuVSMatrix.DataType dataType | ||
| ) { | ||
| try { | ||
| return (CuVSMatrix) createDatasetWithStrides$mh.invokeExact(memorySegment, size, dimensions, rowStride, columnStride, dataType); |
There was a problem hiding this comment.
As we don't need columnStride and it's not really supported (yet) in cuvs-java, I think you might want to pass -1 here like you did in 14088bd. So you can remove all the int columnStride params from all these functions and just have rowStride.
But up to you (I'm fine either way).
There was a problem hiding this comment.
Thanks, may be we can keep this here similar to cuvs DatasetHelper. and adjust it later if needed.
Removed changing flag from cuvs-java dependency.
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Oct 7, 2025
This updates GPU Plugin to a newer CUVS version Co-authored-by: Brian Seeders <[email protected]>
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 8, 2025
This updates GPU Plugin to a newer CUVS version Co-authored-by: Brian Seeders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Nvidia CUVS java library to a newer version that includes strides
Co-authored-by: Brian Seeders [email protected]