From bcc8a5a65ce228eacdbcc31a9568c0a7f92dccff Mon Sep 17 00:00:00 2001 From: afoucret Date: Tue, 7 Oct 2025 09:37:30 +0200 Subject: [PATCH 1/2] Fix misleading error message in tests BreakerTestUtil --- .../src/main/java/org/elasticsearch/test/BreakerTestUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java b/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java index 50af6a453cefb..c84bae1e24645 100644 --- a/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java +++ b/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java @@ -53,7 +53,7 @@ public static ByteSizeValue findBreakerLimit(ByteSizeValue try { c.accept(onePastLimit); } catch (CircuitBreakingException e) { - throw new IllegalArgumentException("expected runnable to break under a limit of " + onePastLimit + " bytes"); + throw new IllegalArgumentException("expected runnable to not break under a limit of " + onePastLimit + " bytes"); } return limit; } From f19f5f127f8aa91383bbd7594af457b02f4add3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20FOUCRET?= Date: Tue, 7 Oct 2025 09:59:45 +0200 Subject: [PATCH 2/2] Apply review feedback Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com> --- .../src/main/java/org/elasticsearch/test/BreakerTestUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java b/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java index c84bae1e24645..d0a69de771ddf 100644 --- a/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java +++ b/test/framework/src/main/java/org/elasticsearch/test/BreakerTestUtil.java @@ -53,7 +53,7 @@ public static ByteSizeValue findBreakerLimit(ByteSizeValue try { c.accept(onePastLimit); } catch (CircuitBreakingException e) { - throw new IllegalArgumentException("expected runnable to not break under a limit of " + onePastLimit + " bytes"); + throw new IllegalArgumentException("expected runnable to *not* break under a limit of " + onePastLimit + " bytes"); } return limit; }