From 2fd130e617ca2a01244e7b2bd38355d0c11c5baa Mon Sep 17 00:00:00 2001
From: Ryan Ernst <ryan@iernst.net>
Date: Fri, 10 Oct 2025 07:45:07 -0700
Subject: [PATCH] Remove PreShardSyncedFlush

This action/request existed for compatibility with 7.17 and is no longer
used in 9.x. With this removal the V_8_0_0 transport version constant is
no longer used, and removed as well.
---
 .../org/elasticsearch/TransportVersions.java  |  1 -
 .../flush/TransportShardFlushAction.java      | 52 -------------------
 2 files changed, 53 deletions(-)

diff --git a/server/src/main/java/org/elasticsearch/TransportVersions.java b/server/src/main/java/org/elasticsearch/TransportVersions.java
index 8922c2bfa4131..dcdcc3c640fb9 100644
--- a/server/src/main/java/org/elasticsearch/TransportVersions.java
+++ b/server/src/main/java/org/elasticsearch/TransportVersions.java
@@ -60,7 +60,6 @@ static TransportVersion def(int id) {
     public static final TransportVersion V_7_8_1 = def(7_08_01_99);
     public static final TransportVersion V_7_9_0 = def(7_09_00_99);
     public static final TransportVersion V_7_10_0 = def(7_10_00_99);
-    public static final TransportVersion V_8_0_0 = def(8_00_00_99);
     public static final TransportVersion V_8_8_0 = def(8_08_00_99);
     public static final TransportVersion V_8_8_1 = def(8_08_01_99);
     /*
diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/flush/TransportShardFlushAction.java b/server/src/main/java/org/elasticsearch/action/admin/indices/flush/TransportShardFlushAction.java
index c0a3e568ffeeb..f05e16bc07897 100644
--- a/server/src/main/java/org/elasticsearch/action/admin/indices/flush/TransportShardFlushAction.java
+++ b/server/src/main/java/org/elasticsearch/action/admin/indices/flush/TransportShardFlushAction.java
@@ -9,7 +9,6 @@
 
 package org.elasticsearch.action.admin.indices.flush;
 
-import org.elasticsearch.TransportVersions;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.action.ActionType;
 import org.elasticsearch.action.support.ActionFilters;
@@ -18,17 +17,11 @@
 import org.elasticsearch.cluster.action.shard.ShardStateAction;
 import org.elasticsearch.cluster.service.ClusterService;
 import org.elasticsearch.common.io.stream.StreamInput;
-import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.index.shard.IndexShard;
-import org.elasticsearch.index.shard.ShardId;
 import org.elasticsearch.indices.IndicesService;
 import org.elasticsearch.injection.guice.Inject;
-import org.elasticsearch.tasks.Task;
 import org.elasticsearch.threadpool.ThreadPool;
-import org.elasticsearch.transport.AbstractTransportRequest;
-import org.elasticsearch.transport.TransportChannel;
-import org.elasticsearch.transport.TransportRequestHandler;
 import org.elasticsearch.transport.TransportService;
 
 import java.io.IOException;
@@ -64,12 +57,6 @@ public TransportShardFlushAction(
             PrimaryActionExecution.RejectOnOverload,
             ReplicaActionExecution.SubjectToCircuitBreaker
         );
-        transportService.registerRequestHandler(
-            PRE_SYNCED_FLUSH_ACTION_NAME,
-            threadPool.executor(ThreadPool.Names.FLUSH),
-            PreShardSyncedFlushRequest::new,
-            new PreSyncedFlushTransportHandler(indicesService)
-        );
     }
 
     @Override
@@ -96,43 +83,4 @@ protected void shardOperationOnReplica(ShardFlushRequest request, IndexShard rep
             return new ReplicaResult();
         }));
     }
-
-    // TODO: Remove this transition in 9.0
-    private static final String PRE_SYNCED_FLUSH_ACTION_NAME = "internal:indices/flush/synced/pre";
-
-    private static class PreShardSyncedFlushRequest extends AbstractTransportRequest {
-        private final ShardId shardId;
-
-        private PreShardSyncedFlushRequest(StreamInput in) throws IOException {
-            super(in);
-            assert in.getTransportVersion().before(TransportVersions.V_8_0_0) : "received pre_sync request from a new node";
-            this.shardId = new ShardId(in);
-        }
-
-        @Override
-        public String toString() {
-            return "PreShardSyncedFlushRequest{" + "shardId=" + shardId + '}';
-        }
-
-        @Override
-        public void writeTo(StreamOutput out) throws IOException {
-            assert false : "must not send pre_sync request from a new node";
-            throw new UnsupportedOperationException("");
-        }
-    }
-
-    private static final class PreSyncedFlushTransportHandler implements TransportRequestHandler<PreShardSyncedFlushRequest> {
-        private final IndicesService indicesService;
-
-        PreSyncedFlushTransportHandler(IndicesService indicesService) {
-            this.indicesService = indicesService;
-        }
-
-        @Override
-        public void messageReceived(PreShardSyncedFlushRequest request, TransportChannel channel, Task task) {
-            IndexShard indexShard = indicesService.indexServiceSafe(request.shardId.getIndex()).getShard(request.shardId.id());
-            indexShard.flush(new FlushRequest().force(false).waitIfOngoing(true));
-            throw new UnsupportedOperationException("Synced flush was removed and a normal flush was performed instead.");
-        }
-    }
 }