ESQL: Propagate min transport version into query planning #136479
+668
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with PlannerSettings
alex-spies
added
>non-issue
auto-backport
except local planning
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
commented
Oct 14, 2025
| /** | ||
| * Values for cluster level settings used during query analysis. | ||
| */ | ||
| public record AnalyzerSettings( |
There was a problem hiding this comment.
Mostly unrelated cleanup: This got renamed from EsqlQueryClusterSettings because these are only relevant for the analyzer. Also aligned with our PlannerSettings.java.
alex-spies
commented
Oct 14, 2025
|
|
||
| private static final TransportVersion ESQL_FIELD_ATTRIBUTE_DROP_TYPE = TransportVersion.fromName("esql_field_attribute_drop_type"); | ||
| // Only public for testing | ||
| public static final TransportVersion ESQL_FIELD_ATTRIBUTE_DROP_TYPE = TransportVersion.fromName("esql_field_attribute_drop_type"); |
There was a problem hiding this comment.
I just needed one public transport version that's not pre-8.17 :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #131108
Make the minimum transport version available during query planning, so queries can be planned differently if older nodes (or remote clusters) are to take part in the query execution.
More specifically, plug the minimum transport version into:
This means that the whole pipeline from analyzer via logical optimizer and friends until the physical optimizer, which produces the final physical plan, are now aware of the minimum transport version available in this and remote clusters (which participate in the query).
Also, make the tests use a random compatible transport version per default (but ensure the version is consistent across the analysis-optimization pipeline).
This should keep us on our toes for when query plans diverge on newer versions - this will normally require one test for the current transport version and another one for the previous versions.