Replace TransportVersion.onOrAfter with TransportVersion.supports
#136760
Conversation
jdconrad
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
LGTM, just a couple suggestions for followups
|
|
||
| @Override | ||
| public boolean before(TransportVersion version) { | ||
| return version.id() > id(); |
There was a problem hiding this comment.
Can we throw UOE here as well, suggesting .supports(...) == false? Or is that intended for a followup?
There was a problem hiding this comment.
That will 100% be a follow up. I just prefer to do one method at at time given how large this change is.
| } | ||
|
|
||
| @Override | ||
| public boolean between(TransportVersion lowerInclusive, TransportVersion upperExclusive) { |
There was a problem hiding this comment.
Like the above, can this be blocked in a followup?
| * <li>{@code 8_801_0_00.isPatchFrom(8_800_0_04)}: {@code false}</li> | ||
| * </ul> | ||
| */ | ||
| public boolean isPatchFrom(TransportVersion version) { |
There was a problem hiding this comment.
It looks like there are only a handful of remaining uses, perhaps these versions could be manually migrated (building a chained TransportVersion in memory) so that they can use supports and this could be made private?
There was a problem hiding this comment.
That's a good idea. I will look into that.
|
I'm closing this in favor of other refactoring work first. |
3 participants
Note this changes
TransportVersion.onOrAfterto throw anUnsupportedOperationException.ES-12334