ESQL: Unmute generative tests that fail with wrong optimization #137000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-spies
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
added
the
auto-merge-without-approval
cimequinox
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Removes "optimized incorrectly due to missing references" from ALLOWED_ERRORS as described.
Elasticsearch Serverless Checks did not pass due to what appears to be same unrelated infrastructure issue seen today in another PR #137006 (review)
|
Thanks folks! Unmuting this actually uncovered an issue; this is blocking on #137019, I'm in the process of fixing this. |
💚 Backport successful
|
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Oct 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were muted due to #131509, which was fixed in #132455.
Let's unmute, so we don't fly blind with respect to inconsistent optimizations and have the generative tests catch them again.