Fixing data stream support in random sampling #137271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for data streams in the sampling service. The changes enable sampling configurations to be applied to data streams in addition to regular indices, and ensure that sampling configurations are properly cleaned up when data streams are deleted.
Key changes:
- New utility method to validate that a request targets either a data stream or a single existing index
- Automatic cleanup of sampling configurations when data streams are deleted
- Comprehensive test coverage for data stream operations including creation, deletion, and sampling
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SamplingService.java | Added validation method for data streams/indices and cleanup logic for deleted data streams |
| TransportPutSampleConfigurationAction.java | Updated to use new validation method supporting data streams |
| TransportGetSampleStatsAction.java | Updated to use new validation method supporting data streams |
| TransportGetSampleAction.java | Updated to use new validation method supporting data streams |
| TransportDeleteSampleConfigurationAction.java | Updated to use new validation method supporting data streams |
| GetSampleStatsAction.java | Added includeDataStreams() override to enable data stream support |
| SamplingServiceIT.java | Added integration test for data stream deletion cleanup |
| 30_with_data_streams.yml (get_sample_stats) | Added comprehensive YAML test suite for sample stats with data streams |
| 30_with_data_streams.yml (get_sample) | Added comprehensive YAML test suite for getting samples from data streams |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 29, 2025
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
…7301) I failed to merge in main before merging elastic#137271 so I didn't pick up the changes in elastic#137290. This accounts for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some parts of random sampling that would break when using data streams instead of ordinary indices. This fixes those, and adds some tests.