Skip to content

ESQL: Fix incorrect exponential histogram sub-block serialization. #137279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JonasKunz merged 2 commits into from
Oct 29, 2025
Merged

ESQL: Fix incorrect exponential histogram sub-block serialization. #137279

JonasKunz merged 2 commits into from
Oct 29, 2025

Conversation

@JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Oct 28, 2025

Follow-up for #133393 (comment).

Adds a test-case which would surface the error due to the previous, wrong implementation and fixes the serialization/deserialization logic.

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.3.0 labels Oct 28, 2025
@JonasKunz JonasKunz marked this pull request as ready for review October 28, 2025 17:31
@JonasKunz JonasKunz requested a review from dnhatn October 28, 2025 17:31
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 28, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 28, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

@JonasKunz JonasKunz mentioned this pull request Oct 28, 2025
Merged
dnhatn
dnhatn approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Jonas!

@limotova We might need a similar fix for aggregate_metric_double.

@JonasKunz JonasKunz merged commit aebedd6 into elastic:main Oct 29, 2025
34 checks passed
@JonasKunz JonasKunz deleted the fix-exp-histo-block-serialization branch October 29, 2025 07:28
limotova added a commit to limotova/elasticsearch that referenced this pull request Oct 29, 2025
@limotova
[ES|QL] Fix agg_metric_double sub-block serialization
5ecc9fd 
Fixes serializing error when sub-blocks are ConstantNullBlocks.
Related to elastic#137279
@limotova limotova mentioned this pull request Oct 29, 2025
Draft
limotova added a commit to limotova/elasticsearch that referenced this pull request Oct 29, 2025
@limotova
[ES|QL] Fix agg_metric_double sub-block serialization
2b8d23f 
Fixes serializing error when sub-blocks are ConstantNullBlocks.
Related to elastic#137279
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Nov 3, 2025
@JonasKunz @chrisparrinello
Fix incorrect exponential histogram sub-block serialization. (elastic…
d4a660d 
…#137279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonasKunz @elasticsearchmachine @dnhatn