[Sampling] update sampling config get all response to fit elastic standards #137290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the get_all_sample_configuration API response format to conform with Elastic API standards by wrapping the array of configurations in a named object property. Previously, the API returned a raw array, but now it returns an object with a "configurations" property containing the array.
- Updated the response structure to wrap the configuration array in a named "configurations" property
- Modified all corresponding test assertions to reference the new nested structure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GetAllSampleConfigurationAction.java | Updated toXContent method to wrap the configurations array in an object with "configurations" property |
| 10_basic.yml | Updated all test assertions to reference the new "configurations" property instead of accessing the raw array |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seanzatzdev
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 28, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 29, 2025
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
…7301) I failed to merge in main before merging elastic#137271 so I didn't pick up the changes in elastic#137290. This accounts for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to create the rest api spec for the new sampling config APIs, i encountered an error due to the get_all_sample_configuration response's array not being named.
This PR updates the get_all_sample_configuration response to name the returned array in order to conform with elastic API standards.