ESQL: Extends constant MVs handling with warnings to general binary comparisons #137387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @astefan, I've created a changelog YAML for you. |
…com/astefan/elasticsearch into MVs_warnings_for_binary_comparisons
…MVs_warnings_for_binary_comparisons
fang-xing-esql
approved these changes
Oct 31, 2025
Member
fang-xing-esql
left a comment
fang-xing-esql
left a comment
There was a problem hiding this comment.
LGTM, thank you @astefan !
bpintea
approved these changes
Nov 1, 2025
Contributor
bpintea
left a comment
bpintea
left a comment
There was a problem hiding this comment.
LGTM.
I guess we can now remove the same check in Equals?
astefan
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
Nop, we cannot. The checks have a different order in which they are called and for |
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Nov 1, 2025
…omparisons (elastic#137387) (cherry picked from commit 5e35a4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #137032 by using the same mechanism, but extended to EsqlBinaryComparison.