Fix race condition in async task reschedule test #137405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes elastic#131150
rjernst
added
>test
elasticsearchmachine
added
v9.2.1
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 31, 2025
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes elastic#131150
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 31, 2025
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes elastic#131150
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 31, 2025
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes elastic#131150
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 31, 2025
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes #131150
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 31, 2025
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes #131150
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 31, 2025
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier. This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok. closes #131150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rescheduling a task, the task may begin running before the test is able to take more actions. This means reseting the barriers in the auto reschedule test may occur after the second run of the task has begun, which results in a broken barrier.
This commit fixes the race condition by moving the reset of each barrier to occur after the await for the relevant barrier. This ensures that each barrier is ready to be awaited on again by the end of the run. Due to there being two barriers, the second barrier may be reset after the test codes second barrier1.await, but that is ok.
closes #131150