Wire cps check #137446
Draft
Wire cps check #137446
+84
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>non-issue
Team:Analytics
idegtiarenko
commented
Oct 31, 2025
| final String clusterAlias = entry.getKey(); | ||
| final String indexExpr = Strings.arrayToCommaDelimitedString(entry.getValue().indices()); | ||
| executionInfo.swapCluster(clusterAlias, (k, v) -> { | ||
| assert v == null : "No cluster for " + clusterAlias + " should have been added to ExecutionInfo yet"; |
There was a problem hiding this comment.
Now this is called in a loop since we might encounter several main index expression (for example in fork or in view).
This should concatenate all of their expressions in the same cluster entry.
idegtiarenko
commented
Oct 31, 2025
| result, | ||
| (entry, r, l) -> preAnalyzeMainIndices(entry.getKey(), entry.getValue(), preAnalysis, executionInfo, r, requestFilter, l), | ||
| listener | ||
| ); |
There was a problem hiding this comment.
This is going to be hidden behind crossProjectModeDecider.crossProjectEnabled() == false check.
For CPS case we are going to perform resolution somewhat differently.
Completeness and correctness of resolution would be handled by FC completely, the EsqlExecutionInfo#clusterInfo will be populated from the FC resolvedTo data structure added by #136632.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.