Move RegisteredPolicySnapshots XContent registry entry to ClusterModule
#137500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule` This `ProjectCustom` class is currently registered as a writeable in `ClusterModule` and its XContent entry is registered in the SLM plugin. We use `RegisteredPolicySnapshots` in the `SnapshotsService`, so we should move its XContent entry to `ClusterModule` as well. This avoids the following warning from showing up in some tests: > Skipping unknown custom [ProjectCustom] object with type registered_snapshots
nielsbauman
added
>non-issue
:Data Management/ILM+SLM
elasticsearchmachine
added
v9.3.0
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the XContent registry entry for RegisteredPolicySnapshots from the SLM plugin to ClusterModule to align with where its writeable registration already exists, eliminating test warnings about unknown custom objects.
- Removes
RegisteredPolicySnapshotsXContent registration fromSnapshotLifecycleplugin - Adds
RegisteredPolicySnapshotsXContent registration toClusterModule
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycle.java | Removes the XContent registry entry and import for RegisteredPolicySnapshots |
| server/src/main/java/org/elasticsearch/cluster/ClusterModule.java | Adds the XContent registry entry for RegisteredPolicySnapshots |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
ProjectCustomclass is currently registered as a writeable inClusterModuleand its XContent entry is registered in the SLM plugin. We useRegisteredPolicySnapshotsin theSnapshotsService, so we should move its XContent entry toClusterModuleas well.This avoids the following warning from showing up in some tests: