Add a test that exercises two little known conditional processor paths #137645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>test
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
jdconrad
approved these changes
Nov 5, 2025
masseyke
approved these changes
Nov 5, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Nov 6, 2025
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Nov 6, 2025
…-json
* upstream/main:
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=false} elastic#137691
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=true} elastic#137690
[LTR] Fix feature display order when using explain. (elastic#137671)
Remove extra RemoteClusterService instances in unit test (elastic#137647)
Fix `ComponentTemplatesFileSettingsIT.testSettingsApplied` (elastic#137669)
Consolidates troubleshooting content into the "Returning semantic field embeddings in _source" section (elastic#137233)
Update bundled JDK to 25.0.1 (elastic#137640)
resolve indices for prefixed _all expressions (elastic#137330)
ESQL: Add TopN support for exponential histograms (elastic#137313)
allows field caps to be cross project (elastic#137530)
ESQL: Add exponential histogram percentile function (elastic#137553)
Wait for nodes to have downloaded databases in `GeoIpDownloaderIT` (elastic#137636)
Tighten on when THROTTLE decision can be returned (elastic#136794)
Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeMetricsIT test elastic#137655
Add a test for two little known conditional processor paths (elastic#137645)
Extract a common ORIGIN constant (elastic#137612)
Remove early phase failure in batched (elastic#136889)
Returning correct index mode from get data streams api (elastic#137646)
[ML] Manage AD results indices (elastic#136065)
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Nov 6, 2025
…-json
* upstream/main:
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=false} elastic#137691
Mute org.elasticsearch.xpack.inference.action.filter.ShardBulkInferenceActionFilterBasicLicenseIT testLicenseInvalidForInference {p0=true} elastic#137690
[LTR] Fix feature display order when using explain. (elastic#137671)
Remove extra RemoteClusterService instances in unit test (elastic#137647)
Fix `ComponentTemplatesFileSettingsIT.testSettingsApplied` (elastic#137669)
Consolidates troubleshooting content into the "Returning semantic field embeddings in _source" section (elastic#137233)
Update bundled JDK to 25.0.1 (elastic#137640)
resolve indices for prefixed _all expressions (elastic#137330)
ESQL: Add TopN support for exponential histograms (elastic#137313)
allows field caps to be cross project (elastic#137530)
ESQL: Add exponential histogram percentile function (elastic#137553)
Wait for nodes to have downloaded databases in `GeoIpDownloaderIT` (elastic#137636)
Tighten on when THROTTLE decision can be returned (elastic#136794)
Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeMetricsIT test elastic#137655
Add a test for two little known conditional processor paths (elastic#137645)
Extract a common ORIGIN constant (elastic#137612)
Remove early phase failure in batched (elastic#136889)
Returning correct index mode from get data streams api (elastic#137646)
[ML] Manage AD results indices (elastic#136065)
Contributor
Author
|
#137692 is up for the 8.19 backport, so I'm removing the |
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These work, and probably have worked forever, but I don't think we document it anywhere. I think it would be useful to have test coverage for these behaviors since they're somewhat obscure.
First, conditionals are commonly seen to have expressions. But they can also have statements. This can be useful as an optimization. For example, this expression:
Can be rewritten as these statements:
The latter approach might be faster than the former (note: you should profile your code, not trust random github PR descriptions) because it descends the
ctxobject tree via chainedMap#getinvocations just once, rather than up to three times.Second, did you know that
"if"doesn't have to be aString? It can be a map, too! And the map can haveparams. An especially useful application of this trick would be a conditional that's checking a candidate value against a large group of other values, like what one might choose to do here.To my understanding, as written, that example currently compiles down to bytecode that creates an empty
ArrayList, then adds twelve strings to it (note: the ArrayList is resized from the default capacity of 10 to a capacity of 15 in order to accommodate the 11th string, with the ensuing array copy), and then a linear scan of theArrayListis performed in the.contains(...). And that's all performed for every document that goes through the thus-defined processor.By way of contrast, this would work similarly in terms of effect, but be much faster (note: assuming flow-style inline maps are supported by whatever is handling the yaml there, otherwise the syntax would be slightly different):
This version is admittedly a bit uglier, but since it generates a single static params map of all the values just once at script definition time and then does a fast
containsKeycheck on that map, it's quite a bit faster (and allocation-free).The most ideal version of that might not rely on the set semantics of the map keys, but in the absence of support for constant set collections in painless, this is probably the optimal mix of readable and fast for the state of the current technology.