Skip to content

Conversation

@benwtrent
Copy link
Member

@benwtrent benwtrent commented Nov 11, 2025

This changes the work flow a bit:

To build and copy, you simply need to do:

# indicate that we are using local build
export LOCAL_VEC_BINARY_OS=darwin
# get to the build dir
cd libs/simdvec/native
# build it and copy it
JAVA_HOME=$JAVA21_HOME ./gradlew buildSharedLibraryAndCopy
# do what you want, it will now use the locally built value

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Nov 11, 2025
}
}

tasks.register('buildSharedLibraryAndCopy') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-vieira is there a more canonical way to wire this for local building over to libs/native?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more idiomatic way would probably be to use composite builds here. If we configured this project to publish the zip as an artifact, configure it with the same maven coordinates as the binary artifact, then in theory we could just use --include-build libs/simdvec/native to get the same behavior.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what composite builds are :/

My end goal is to provide simplified mechanisms not only for local testing but to unlock us writing up some buildkite jobs to build and benchmark native code changes (will be in subsequent PRs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this unblocks you for now, seems fine to me. We can always improve this. @elastic/es-delivery should have some eyes on this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants