-
Notifications
You must be signed in to change notification settings - Fork 25.6k
This partially simplifies the local native vec testing, more work to be done #137904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benwtrent
wants to merge
6
commits into
elastic:main
Choose a base branch
from
benwtrent:simplify-local-native-vec-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−4
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ef3d997
This partially simplifies the local native vec testing, more work to …
benwtrent c5b394e
Adding logic to copy built native lib
benwtrent c71a1b4
iter
benwtrent a8bf6b9
Merge branch 'main' into simplify-local-native-vec-testing
benwtrent 11a1397
Update libs/simdvec/native/build.gradle
benwtrent 9dca3f7
Merge branch 'main' into simplify-local-native-vec-testing
benwtrent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-vieira is there a more canonical way to wire this for local building over to libs/native?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The more idiomatic way would probably be to use composite builds here. If we configured this project to publish the zip as an artifact, configure it with the same maven coordinates as the binary artifact, then in theory we could just use
--include-build libs/simdvec/nativeto get the same behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what composite builds are :/
My end goal is to provide simplified mechanisms not only for local testing but to unlock us writing up some buildkite jobs to build and benchmark native code changes (will be in subsequent PRs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this unblocks you for now, seems fine to me. We can always improve this. @elastic/es-delivery should have some eyes on this though.