diff --git a/modules/repository-s3/src/javaRestTest/java/org/elasticsearch/repositories/s3/RepositoryS3ConditionalWritesUnsupportedRestIT.java b/modules/repository-s3/src/javaRestTest/java/org/elasticsearch/repositories/s3/RepositoryS3ConditionalWritesUnsupportedRestIT.java index 2874164f9a047..1ac7435dc7750 100644 --- a/modules/repository-s3/src/javaRestTest/java/org/elasticsearch/repositories/s3/RepositoryS3ConditionalWritesUnsupportedRestIT.java +++ b/modules/repository-s3/src/javaRestTest/java/org/elasticsearch/repositories/s3/RepositoryS3ConditionalWritesUnsupportedRestIT.java @@ -97,7 +97,7 @@ public void handle(HttpExchange exchange) throws IOException { protected Settings extraRepositorySettings() { return Settings.builder() .put(super.extraRepositorySettings()) - .put(S3Repository.UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES.getKey(), true) + .put(S3Repository.UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES.getKey(), true) .build(); } diff --git a/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java b/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java index 7ccb20c5bf9aa..1b2ce77c2a7b6 100644 --- a/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java +++ b/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java @@ -630,7 +630,7 @@ public void addPurposeQueryParameter(OperationPurpose purpose, AwsRequestOverrid /** * Some storage claims S3-compatibility despite failing to support the {@code If-Match} and {@code If-None-Match} functionality * properly. We allow to disable the use of this functionality, making all writes unconditional, using the - * {@link S3Repository#UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES} setting. + * {@link S3Repository#UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES} setting. */ public boolean supportsConditionalWrites(OperationPurpose purpose) { // REPOSITORY_ANALYSIS is a strict check for 100% S3 compatibility, including conditional write support diff --git a/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Repository.java b/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Repository.java index 88b294518e42f..5cc4eaa22e3bb 100644 --- a/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Repository.java +++ b/modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3Repository.java @@ -249,7 +249,7 @@ class S3Repository extends MeteredBlobStoreRepository { Setting.Property.Dynamic ); - static final Setting UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES = Setting.boolSetting( + static final Setting UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES = Setting.boolSetting( "unsafely_incompatible_with_s3_conditional_writes", false ); @@ -279,7 +279,7 @@ class S3Repository extends MeteredBlobStoreRepository { /** * Some storage claims S3-compatibility despite failing to support the {@code If-Match} and {@code If-None-Match} functionality * properly. We allow to disable the use of this functionality, making all writes unconditional, using the - * {@link #UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES} setting. + * {@link #UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES} setting. */ private final boolean supportsConditionalWrites; @@ -359,7 +359,7 @@ class S3Repository extends MeteredBlobStoreRepository { } coolDown = COOLDOWN_PERIOD.get(metadata.settings()); - supportsConditionalWrites = UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES.get(metadata.settings()) == Boolean.FALSE; + supportsConditionalWrites = UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES.get(metadata.settings()) == Boolean.FALSE; if (supportsConditionalWrites == false) { logger.warn( @@ -368,7 +368,7 @@ class S3Repository extends MeteredBlobStoreRepository { this warning, upgrade your storage to a system that is fully compatible with AWS S3 and then remove the [{}] \ repository setting; for more information, see [{}]""", metadata.name(), - UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES.getKey(), + UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES.getKey(), ReferenceDocs.S3_COMPATIBLE_REPOSITORIES ); } diff --git a/modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java b/modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java index 0a208c5241cf1..e217cffc6d3aa 100644 --- a/modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java +++ b/modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java @@ -249,7 +249,7 @@ protected BlobContainer createBlobContainer( S3Repository.MAX_COPY_SIZE_BEFORE_MULTIPART.getDefault(Settings.EMPTY), S3Repository.CANNED_ACL_SETTING.getDefault(Settings.EMPTY), S3Repository.STORAGE_CLASS_SETTING.getDefault(Settings.EMPTY), - S3Repository.UNSAFELY_INCOMPATIBLE_WITH_S3_WRITES.getDefault(Settings.EMPTY), + S3Repository.UNSAFELY_INCOMPATIBLE_WITH_S3_CONDITIONAL_WRITES.getDefault(Settings.EMPTY), repositoryMetadata, BigArrays.NON_RECYCLING_INSTANCE, new DeterministicTaskQueue().getThreadPool(),