Add OffHeapBytesSizes for Stats #138433
Merged
Add OffHeapBytesSizes for Stats #138433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2025
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
reviewed
Nov 21, 2025
| // var centroids = Map.of(EXTENSION, fe.xxxLength()); | ||
| // var clusters = Map.of(EXTENSION, fe.yyyLength()); | ||
| // return KnnVectorsReader.mergeOffHeapByteSizeMaps(raw, centroids, clusters); | ||
| // TODO: report on desired off-heap requirements instead or in addition to max? |
Member
There was a problem hiding this comment.
I don't think we can indicate "desired" here, it will always be weird given the user query patterns.
Contributor
Author
There was a problem hiding this comment.
fair enough i'll nix the todo
benwtrent
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (or at least starts to address): #128458
This addresses reporting on the bytes used by diskbbq by exposing the sizes of the centroids and postings list files. While we don't always need the entire structure off heap this is better than reporting 0s. The docs will be updated a good bit to reflect this. At some point in the future we should revisit if we want to report something smaller or somehow report an estimate for what needs to be resident in off heap ram.
This wil require updates to docs and specifications. Those PRs are here:
There are also updates needed for esdiag and all of the clients and I'll reach out separately on those.