-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Handle individual doc parsing failure in bulk request with pipeline #138624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @samxbr, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
PeteGillinElastic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple of nits around some mockito syntax to avoid those unchecked conversions.
server/src/test/java/org/elasticsearch/ingest/IngestServiceTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/ingest/IngestServiceTests.java
Outdated
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
… pipeline (elastic#138624) (cherry picked from commit 933354b)
… pipeline (elastic#138624) (cherry picked from commit 933354b)
… pipeline (elastic#138624) (cherry picked from commit 933354b)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
… pipeline (elastic#138624) (cherry picked from commit 933354b)
|
Not backporting to 8.18 and 9.0 as they are no longer maintained. The bug fix will be backported to |
…st with pipeline (#138624) (#138708) * Handle individual doc parsing failure gracefully in bulk request with pipeline (#138624) (cherry picked from commit 933354b) * [CI] Auto commit changes from spotless * Fix missing methods * fix test --------- Co-authored-by: elasticsearchmachine <[email protected]>
Handle individual doc parsing failure gracefully in a bulk request with pipeline, to prevent the whole bulk request failing due to a single doc failure.
Closes #138445