diff --git a/modules/reindex/src/test/java/org/elasticsearch/reindex/ReindexerTests.java b/modules/reindex/src/test/java/org/elasticsearch/reindex/ReindexerTests.java index d7dad3b6ad9b9..fa5660d5d2e75 100644 --- a/modules/reindex/src/test/java/org/elasticsearch/reindex/ReindexerTests.java +++ b/modules/reindex/src/test/java/org/elasticsearch/reindex/ReindexerTests.java @@ -780,12 +780,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -793,7 +787,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1089,12 +1083,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1102,7 +1090,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1169,12 +1157,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1182,7 +1164,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1244,11 +1226,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1256,7 +1233,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1265,7 +1242,8 @@ public ExecutorService executor(String name) { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); final var termQuery = QueryBuilders.termQuery("field", "value"); @@ -1317,12 +1295,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1330,7 +1302,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1394,12 +1366,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1407,7 +1373,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1474,12 +1440,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1487,7 +1447,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1550,12 +1510,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1563,7 +1517,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1626,20 +1580,14 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); FeatureService featureService = mock(FeatureService.class); when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); - when(clusterService.getSettings()).thenReturn(Settings.EMPTY); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1744,7 +1692,7 @@ public ExecutorService executor(String name) { ); try { final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1753,7 +1701,8 @@ public ExecutorService executor(String name) { null, transportService, mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); reindexerRef.set(reindexer); @@ -1851,11 +1800,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1863,7 +1807,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1872,7 +1816,8 @@ public ExecutorService executor(String name) { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); final int scrollMinutes = randomIntBetween(3, 20); @@ -1925,11 +1870,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -1937,7 +1877,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -1946,7 +1886,8 @@ public ExecutorService executor(String name) { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); final ReindexRequest request = new ReindexRequest(); @@ -1997,11 +1938,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -2009,7 +1945,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -2018,7 +1954,8 @@ public ExecutorService executor(String name) { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); final IndicesOptions indicesOptions = IndicesOptions.lenientExpandOpen(); @@ -2069,11 +2006,6 @@ public ExecutorService executor(String name) { } }; try { - final ClusterService clusterService = mock(ClusterService.class); - final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); - when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); - when(clusterService.localNode()).thenReturn(localNode); - final ProjectResolver projectResolver = mock(ProjectResolver.class); when(projectResolver.getProjectState(any())).thenReturn(ClusterState.EMPTY_STATE.projectState(Metadata.DEFAULT_PROJECT_ID)); @@ -2081,7 +2013,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(false); final Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, client, threadPool, @@ -2090,7 +2022,8 @@ public ExecutorService executor(String name) { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); final ReindexRequest request = new ReindexRequest(); @@ -2197,7 +2130,7 @@ public ExecutorService executor(String name) { when(featureService.clusterHasFeature(any(), eq(ReindexPlugin.REINDEX_PIT_SEARCH_FEATURE))).thenReturn(true); Reindexer reindexer = new Reindexer( - clusterService, + clusterServiceMock(), projectResolver, mock(Client.class), threadPool, @@ -2206,7 +2139,8 @@ public ExecutorService executor(String name) { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - featureService + featureService, + mock(TaskResultsService.class) ); ReindexRequest request = new ReindexRequest(); @@ -2300,7 +2234,7 @@ public void testCloseRestClientAndRunLogsWhenCloseThrows() throws IOException { ThreadPool threadPool = mock(ThreadPool.class); when(threadPool.generic()).thenReturn(DIRECT_EXECUTOR_SERVICE); Reindexer reindexer = new Reindexer( - mock(ClusterService.class), + clusterServiceMock(), mock(ProjectResolver.class), mock(Client.class), threadPool, @@ -2309,7 +2243,8 @@ public void testCloseRestClientAndRunLogsWhenCloseThrows() throws IOException { null, mock(TransportService.class), mock(ReindexRelocationNodePicker.class), - mock(FeatureService.class) + mock(FeatureService.class), + mock(TaskResultsService.class) ); RestClient restClient = mock(RestClient.class); IOException ioException = new IOException("simulated close failure"); @@ -2825,4 +2760,13 @@ private static TaskId randomTaskId() { private static TaskId randomRealTaskId() { return new TaskId(randomAlphaOfLength(10), randomNonNegativeLong()); } + + private static ClusterService clusterServiceMock() { + final ClusterService clusterService = mock(ClusterService.class); + final DiscoveryNode localNode = DiscoveryNodeUtils.builder("local-node").build(); + when(clusterService.state()).thenReturn(ClusterState.EMPTY_STATE); + when(clusterService.localNode()).thenReturn(localNode); + when(clusterService.getSettings()).thenReturn(Settings.EMPTY); + return clusterService; + } }