Fix ticker memory leak in bulk indexer due to internal flush call resetting the ticker. (#797) (#798)

Anaethelion · tblyler · web-flow · commit 2b891aa36bbb · 2024-02-07T18:07:09.000+01:00
Co-authored-by: Tony Blyler &lt;tblyler@users.noreply.github.com&gt;
diff --git a/esutil/bulk_indexer.go b/esutil/bulk_indexer.go
@@ -402,8 +402,8 @@ func (w *worker) run() {
 			w.bi.config.DebugLogger.Printf("[worker-%03d] Started\n", w.id)
 		}
 		defer func() {
-			w.ticker.Stop()
 			w.flush(ctx)
+			w.ticker.Stop()
 			w.bi.wg.Done()
 		}()
 

Original file line number	Diff line number	Diff line change
`@@ -402,8 +402,8 @@ func (w *worker) run() {`
`402`	`402`	`w.bi.config.DebugLogger.Printf("[worker-%03d] Started\n", w.id)`
`403`	`403`	`}`
`404`	`404`	`defer func() {`
`405`		`- w.ticker.Stop()`
`406`	`405`	`w.flush(ctx)`
	`406`	`+ w.ticker.Stop()`
`407`	`407`	`w.bi.wg.Done()`
`408`	`408`	`}()`
`409`	`409`