Reties With not empty URL Path (#657)

* Reties With not empty URL Path

transport builds an incorrect request path if the address is configured with a path, for example:

```
	eCnf := elasticsearch.Config{
		Addresses: []string{
			"https://server.com/somepath"
		},
	}
``` 
it happens when retries is enabled and the API returns an error, transports adds to the request "/somepath" on each retry instead of building a new path.

* Add comment to reset of original path

* Update test to check url after retry

* update variable name following linter recommendations

---------

Co-authored-by: Laurent Saint-Félix <[email protected]>

Author: f-dg

estransport/estransport.go

@@ -327,7 +327,8 @@ func (c *Client) Perform(req *http.Request) (*http.Response, error) {
 			}
 		}
 	}
-
+	
+	originalPath := req.URL.Path
 	for i := 0; i <= c.maxRetries; i++ {
 		var (
 			conn            *Connection
@@ -447,6 +448,10 @@ func (c *Client) Perform(req *http.Request) (*http.Response, error) {
 				break
 			}
 		}
+
+		// Re-init the path of the request to its original state
+		// This will be re-enriched by the connection upon retry
+		req.URL.Path = originalPath
 	}
 
 	// TODO(karmi): Wrap error

estransport/estransport_internal_test.go

@@ -657,7 +657,10 @@ func TestTransportPerformRetries(t *testing.T) {
 
 	t.Run("Reset request body during retry", func(t *testing.T) {
 		var bodies []string
-		u, _ := url.Parse("https://foo.com/bar")
+		esURL := "https://foo.com/bar"
+		endpoint := "/abc"
+
+		u, _ := url.Parse(esURL)
 		tp, _ := New(Config{
 			URLs: []*url.URL{u},
 			Transport: &mockTransp{
@@ -666,6 +669,10 @@ func TestTransportPerformRetries(t *testing.T) {
 					if err != nil {
 						panic(err)
 					}
+					expectedURL := strings.Join([]string{esURL, endpoint}, "")
+					if !strings.EqualFold(req.URL.String(), expectedURL) {
+						t.Fatalf("expected request url to be %s, got: %s", expectedURL, req.URL.String())
+					}
 					bodies = append(bodies, string(body))
 					return &http.Response{Status: "MOCK", StatusCode: 502}, nil
 				},